Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor orders table into consolidated table #62

Merged
merged 16 commits into from
Jul 19, 2024
Merged

refactor orders table into consolidated table #62

merged 16 commits into from
Jul 19, 2024

Conversation

ribeirojose
Copy link
Contributor

@ribeirojose ribeirojose commented Jul 18, 2024 •
edited by yvesfracari
Loading

Still missing:

  • go to order page when clicking order row;
  • review prices;
  • allow user to invert prices;
  • bug when changing row count (must update page count);

@linear Linear
Copy link

linear bot commented Jul 18, 2024

COW-316 I'd add a pagination to order lists (in CoW Swap there are 10 orders per page are displayed)

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composable-cow-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:54pm
composable-cow-hub-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:54pm

@ribeirojose ribeirojose force-pushed the jose/cow-316-id-add-a-pagination-to-order-lists-in-cow-swap-there-are-10 branch from 4751df3 to a3b9a82 Compare July 18, 2024 18:40
@ribeirojose ribeirojose force-pushed the jose/cow-316-id-add-a-pagination-to-order-lists-in-cow-swap-there-are-10 branch from 7bf3f64 to daa5b60 Compare July 18, 2024 19:04
@ribeirojose ribeirojose marked this pull request as ready for review July 18, 2024 19:12
yvesfracari
yvesfracari approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@yvesfracari yvesfracari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring!

ribeirojose and others added 16 commits July 19, 2024 12:51
@ribeirojose ribeirojose force-pushed the jose/cow-316-id-add-a-pagination-to-order-lists-in-cow-swap-there-are-10 branch from d5d87ab to 32f0903 Compare July 19, 2024 15:51
@ribeirojose ribeirojose merged commit c119233 into main Jul 19, 2024
2 of 5 checks passed
@ribeirojose ribeirojose deleted the jose/cow-316-id-add-a-pagination-to-order-lists-in-cow-swap-there-are-10 branch July 19, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvesfracari yvesfracari yvesfracari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ribeirojose @yvesfracari